Poll: CelestiaContent

The place to discuss creating, porting and modifying Celestia's source code.

Should Celestia have separate code and content repositories?

Poll ended at 21.03.2020, 17:57

Yes, it makes it easier to update content separately from code
3
38%
No, it's unclear how it will work and it makes pull requests more difficult
5
63%
 
Total votes: 8

Avatar
Topic author
SevenSpheres
Moderator
Posts: 482
Joined: 08.10.2019
With us: 1 year 1 month

Poll: CelestiaContent

Post #1by SevenSpheres » 14.03.2020, 17:57

In January, onetwothree split Celestia's code and content repositories on GitHub. The reasons for this can be seen in that thread, but I think it was poorly thought out and causes more problems than it solves, specifically:

  • I'm still not sure how compiling/installing Celestia will work with two separate repositories.
  • Two months later, CelestiaContent still hasn't been finalized and there are still data files in the main repository.
  • It's unclear which files should go where; e.g. celestia.cfg is in the main repo, and so is the README file (although onetwothree is now saying that README should be in CelestiaContent!)
  • Related to the above, data maintainers (e.g. me I guess) often have to make two pull requests to update things.

So I'm making it a poll. What does everyone else think?
My Addons: viewtopic.php?f=23&t=19978 • Contributing to development as much as I can • Discord server admin
PC specs: HP desktop, Windows 10 Home 64-bit, Intel Core i7-7700 (3.60 GHz), 16 GB RAM, 1 TB HDD + 128 GB SSD, Intel HD Graphics 630
Celestia versions: 1.5.1, 1.6.1, 1.6.2 (primary), 1.7.0 (latest build + some older ones)

Avatar
LukeCEL
Posts: 361
Joined: 26.09.2017
With us: 3 years 2 months

Post #2by LukeCEL » 14.03.2020, 18:13

Personally I don't think it makes it easier to update the content. A lot of times the source code needs to be updated too, like when there's a change to celestia.cfg, or when there's an associated script that generates the file. I don't like having two PRs: one to update src/tools, and one to update the actual files.

Avatar
Topic author
SevenSpheres
Moderator
Posts: 482
Joined: 08.10.2019
With us: 1 year 1 month

Post #3by SevenSpheres » 14.03.2020, 18:15

LukeCEL wrote:Personally I don't think it makes it easier to update the content.

Neither do I. In the poll option I'm referring to "updates" for end users, since that seems to have been onetwothree's main reason for the split.

LukeCEL wrote:A lot of times the source code needs to be updated too, like when there's a change to celestia.cfg, or when there's an associated script that generates the file. I don't like having two PRs: one to update src/tools, and one to update the actual files.

Yep, this is exactly one of the problems I refer to in the OP.
My Addons: viewtopic.php?f=23&t=19978 • Contributing to development as much as I can • Discord server admin
PC specs: HP desktop, Windows 10 Home 64-bit, Intel Core i7-7700 (3.60 GHz), 16 GB RAM, 1 TB HDD + 128 GB SSD, Intel HD Graphics 630
Celestia versions: 1.5.1, 1.6.1, 1.6.2 (primary), 1.7.0 (latest build + some older ones)

onetwothree
Site Admin
Posts: 519
Joined: 22.09.2018
With us: 2 years 2 months

Post #4by onetwothree » 14.03.2020, 19:39

SevenSpheres wrote: I'm still not sure how compiling/installing Celestia will work with two separate repositories.

Easy. You simply install 2 packages. Actually even before splitting we had 3 packages: 1st with binaries, 2nd with common files e.g. translations, shaders, etc and 3rd with data, e.g. textures, models and catalogues. We also have a meta-package which depends on all of them. Now I have all required files to build data package for Debian using the new repository. I just forget to contact munix9 to update his spec files for OpenSUSE and Markerz regarding macOS bundle.

SevenSpheres wrote: Two months later, CelestiaContent still hasn't been finalized and there are still data files in the main repository.

That's because we build packages only using the main repo still.

SevenSpheres wrote: It's unclear which files should go where; e.g. celestia.cfg is in the main repo, and so is the README file (although onetwothree is now saying that README should be in CelestiaContent!)

One README contains information regarding source code, another one is for data files. They are 2 quite different files. You can remove code related information from current README and copy it to data repository.

SevenSpheres wrote: Related to the above, data maintainers (e.g. me I guess) often have to make two pull requests to update things.

You may consider me rude, but you guys waste much more time discussing useless topics like who should have what colour in discord and here.

Avatar
Topic author
SevenSpheres
Moderator
Posts: 482
Joined: 08.10.2019
With us: 1 year 1 month

Post #5by SevenSpheres » 14.03.2020, 19:47

onetwothree wrote:One README contains information regarding source code, another one is for data files. They are 2 quite different files. You can remove code related information from current README and copy it to data repository.

So what happens when installing files? One file named README overwrites the other file named README??

The whole thing is just a poorly thought out mess.
My Addons: viewtopic.php?f=23&t=19978 • Contributing to development as much as I can • Discord server admin
PC specs: HP desktop, Windows 10 Home 64-bit, Intel Core i7-7700 (3.60 GHz), 16 GB RAM, 1 TB HDD + 128 GB SSD, Intel HD Graphics 630
Celestia versions: 1.5.1, 1.6.1, 1.6.2 (primary), 1.7.0 (latest build + some older ones)

onetwothree
Site Admin
Posts: 519
Joined: 22.09.2018
With us: 2 years 2 months

Post #6by onetwothree » 14.03.2020, 20:41

They will be in different directories.

Avatar
Lafuente_Astronomy
Moderator
Posts: 723
Joined: 04.08.2018
Age: 22
With us: 2 years 3 months
Location: Cebu City, Cebu Province, Philippines
Contact:

Post #7by Lafuente_Astronomy » 14.03.2020, 23:03

I do think they are a mess but that's because of the lack of developers. Perhaps if some corrections and fixes to the code are implemented, it my be justified as separated. Hence, why I voted to keep them separate. But that's just my 2 cents. I'd defer to the devs on this one
Official Administrator of the Celestia Discord Server.
Invite: https://discordapp.com/invite/WEWDcJh
If you don't have a Discord account, register here: https://discordapp.com/register
Have a blessed day.

Avatar
Topic author
SevenSpheres
Moderator
Posts: 482
Joined: 08.10.2019
With us: 1 year 1 month

Post #8by SevenSpheres » 14.03.2020, 23:21

Lafuente_Astronomy wrote:I'd defer to the devs on this one

Remember Luke's words on Discord...

LukeCEL wrote:
Lafuente_Astronomy wrote:And I defer to selden because I myself do not have such knowledge on these things
Currently we are talking about organization. If you have good ideas on how to organize, please contribute! I think that's all that's needed for this conversation, no deep knowledge or expertise needed.
My Addons: viewtopic.php?f=23&t=19978 • Contributing to development as much as I can • Discord server admin
PC specs: HP desktop, Windows 10 Home 64-bit, Intel Core i7-7700 (3.60 GHz), 16 GB RAM, 1 TB HDD + 128 GB SSD, Intel HD Graphics 630
Celestia versions: 1.5.1, 1.6.1, 1.6.2 (primary), 1.7.0 (latest build + some older ones)


Return to “Development”

Who is online