Stars don't show after 10s of millions of light years

Report bugs, bug fixes and workarounds here.
Kochav Israel
Posts: 14
Joined: 17.03.2019
With us: 6 months 3 days

Post #21by Kochav Israel » 17.03.2019, 16:41

Selden, the link is dead.

Janus
Posts: 405
Joined: 13.08.2016
With us: 3 years 1 month

Post #22by Janus » 17.03.2019, 20:03

Sorry about that, spring cleaning and the like happening.

For 1 GigaLY limits, try these instead.

The archive contains commit 5429 compiled via VS2015 all libs set to static linking, no DLLs or redists required.
Also contains some of my personal tweaks from my toy chest since I was working on them today already.

I am prone to clicking on random stars and looking around there, the extras are just one of my ways of doing that.


Janus.

EDIT: Confirming that 1GY is in place.
EDIT2: Typo in attached archive name, is 5429.
Attachments
Celestia-5428-1GY.7z
(2.74 MiB) Downloaded 13 times
Last edited by Janus on 17.03.2019, 23:32, edited 3 times in total.

Avatar
Gurren Lagann
Posts: 148
Joined: 31.01.2018
Age: 13
With us: 1 year 7 months

Post #23by Gurren Lagann » 17.03.2019, 21:16

How about the 1 ly solar system render limit?

Janus
Posts: 405
Joined: 13.08.2016
With us: 3 years 1 month

Post #24by Janus » 17.03.2019, 21:32

Yes, thought I was clear on that.

Avatar
Gurren Lagann
Posts: 148
Joined: 31.01.2018
Age: 13
With us: 1 year 7 months

Post #25by Gurren Lagann » 17.03.2019, 23:01

I don't understand, did you attempt it too? And if so, did it work?

Also, what is the Celestia-5429-2M.7z and Celestia-5429-Src.7z files in the original download?

Janus
Posts: 405
Joined: 13.08.2016
With us: 3 years 1 month

Post #26by Janus » 17.03.2019, 23:36

@Gurren Lagann
    Celestia-5429-1GY.7z 2.7M : Just the executables with the display limit set to 1GLY.
    Celestia-5429-2M.7z 94M : Complete ready to run like above with 2 Million star DB added. Original in place to be renamed for use if desired
    Celestia-5429-Src.7z 68M : Complete ready to compile source tree of commit 5429.
Src file contains Celestia source, along with support libraries, third party code, and working VS2015 sln/vcxproj files in the 'vs' directory.

The archive in post #22 above is basically the same the first one here. The difference is it also includes extra celx commands.


Janus.

Avatar
Gurren Lagann
Posts: 148
Joined: 31.01.2018
Age: 13
With us: 1 year 7 months

Post #27by Gurren Lagann » 17.03.2019, 23:53

Apparently the new version is Celestia 1.7.0 only, while I'm on 1.6.1 since Celestia 1.7.0 wont load properly without a GPU... Can you provide a 1.6.1 version of this patch? Or even a 46 Gly version?

Janus
Posts: 405
Joined: 13.08.2016
With us: 3 years 1 month

Post #28by Janus » 18.03.2019, 00:35

@Gurren Lagann

If you are compiling your own then all you need to do is modify one line to implement the change.

/src/celengine/stardb.cpp:47

constexpr const float STAR_OCTREE_ROOT_SIZE = 1000000000.0f;

Here the constant is set to 1GLY, you can change it to whatever you want and recompile.


As for needing a GPU, I am not sure what you mean.
If you use opengl32.dll with the x86 version, putting it in the celestia directory, it should run, though slowly since all functions will be done in software only.


Janus.

Kochav Israel
Posts: 14
Joined: 17.03.2019
With us: 6 months 3 days

Post #29by Kochav Israel » 29.03.2019, 15:52

Yaaaaaaay I finally got to making this work!

Star at 45 billion ly. In my universe Israel is supposed to be at 370 Mly but eh just a test run.
Attachments
IT WORKS.png

Avatar
Lafuente_Astronomy
Moderator
Posts: 357
Joined: 04.08.2018
Age: 21
With us: 1 year 1 month
Location: Cebu City, Cebu Province, Philippines
Contact:

Post #30by Lafuente_Astronomy » 29.03.2019, 22:12

Kochav Israel wrote:Yaaaaaaay I finally got to making this work!

Star at 45 billion ly. In my universe Israel is supposed to be at 370 Mly but eh just a test run.

Wait, how did you do that? Like how did you enable stars at 45 Billion Ly?
Official Administrator of the Celestia Discord Server.
Invite: https://discordapp.com/invite/WEWDcJh
If you don't have a Discord account, register here: https://discordapp.com/register
Have a blessed day.

Kochav Israel
Posts: 14
Joined: 17.03.2019
With us: 6 months 3 days

Post #31by Kochav Israel » 30.03.2019, 09:45

"If you are compiling your own then all you need to do is modify one line to implement the change.

/src/celengine/stardb.cpp:47

constexpr const float STAR_OCTREE_ROOT_SIZE = 1000000000.0f;"



That's how.

Just find the line in the stardb.cpp and replace 1000000000 with 46000000000

Added after 20 minutes 38 seconds:
However for some reason in me it ceased to work again...

I guess a simple rewriting isn't enough.

Added after 19 minutes 45 seconds:
I have no idea how one second it worked and other second it did not.

Also why does it take so much of re-compilation to enable a tiny feature?

Avatar
Lafuente_Astronomy
Moderator
Posts: 357
Joined: 04.08.2018
Age: 21
With us: 1 year 1 month
Location: Cebu City, Cebu Province, Philippines
Contact:

Post #32by Lafuente_Astronomy » 30.03.2019, 21:48

Well, I guess the program itself is not fully suited to allow immense star distances beyond 10 million ly. But since Janus was able to make a 1GLY version, perhaps you can ask him for help
Official Administrator of the Celestia Discord Server.
Invite: https://discordapp.com/invite/WEWDcJh
If you don't have a Discord account, register here: https://discordapp.com/register
Have a blessed day.


Return to “Bugs”

Who is online

Users browsing this forum: 7 guests