Bug Qt-celestia SVN 5142

Report bugs, bug fixes and workarounds here.
Topic author
Boux
Posts: 435
Joined: 25.08.2004
With us: 16 years 1 month
Location: Brittany, close to the Ocean

Bug Qt-celestia SVN 5142

Post #1by Boux » 08.03.2011, 11:06

Hi all,
Following some recent changes to the QT version source code, qt-celestia will no longer build (SVN 5137-->5142).
The compiler outputs an error that points to line 162 of qtappwin.ccp.
Changing CONFIG_DATA_DIR to a QString like this:

Code: Select all

QString celestia_data_dir = "CONFIG_DATA_DIR";

seems to fix the bug and qt-celestia will build.
Intel core i7 3770 Ivy Bridge @ 4.4 GHz -16 GB ram - 128 GB SSD cache - AMD Radeon 7970 3 GB o'clocked - Windows 7 64 Ultimate / Linux Kubuntu

ajtribick
Developer
Posts: 1807
Joined: 11.08.2003
With us: 17 years 1 month
Location: Switzerland

Re: Bug Qt-celestia SVN 5142

Post #2by ajtribick » 08.03.2011, 18:24

So it seems that fixing it so that you don't have to cd to the source code directory on Linux to run the executable breaks it on Windows (assuming this based on the operating systems listed in your sig - more details of what you are using to compile would be useful please)...

Aaargh.

Avatar
John Van Vliet
Posts: 2748
Joined: 28.08.2002
With us: 18 years

Re: Bug Qt-celestia SVN 5142

Post #3by John Van Vliet » 09.03.2011, 10:29

--- edit ---
Last edited by John Van Vliet on 19.10.2013, 07:58, edited 1 time in total.

Topic author
Boux
Posts: 435
Joined: 25.08.2004
With us: 16 years 1 month
Location: Brittany, close to the Ocean

Re: Bug Qt-celestia SVN 5142

Post #4by Boux » 09.03.2011, 10:34

ajtribick
yes, this is correct, OS is Windows Vista 64.
IDE is VC Express 2008 and QT environment is 4.5.3.
I guess this is all about the black art of programming, hehe, making an improvement or killing one bug somewhere will just make a new bug pop up elsewhere...
Intel core i7 3770 Ivy Bridge @ 4.4 GHz -16 GB ram - 128 GB SSD cache - AMD Radeon 7970 3 GB o'clocked - Windows 7 64 Ultimate / Linux Kubuntu

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 18
With us: 18 years 5 months
Location: Hamburg, Germany

Re: Bug Qt-celestia SVN 5142

Post #5by t00fri » 09.03.2011, 11:39

So it seems that fixing it so that you don't have to cd to the source code directory on Linux to run the executable breaks it on Windows (assuming this based on the operating systems listed in your sig

The CONFIG_DATA_DIR error also persists if r5143 is built with Qt-creator 2.0.94 and QT 4.7.2 under OpenSuSE 11.2!

Fridger

PS:
using precisely these steps:

1) a clean checkout of r5143
2) > touch config.h (i.e no autotools used)
3) compile under qtcreator
Image

Vincent
Developer
Posts: 1356
Joined: 07.01.2005
With us: 15 years 8 months
Location: Nancy, France

Re: Bug Qt-celestia SVN 5142

Post #6by Vincent » 09.03.2011, 12:15

I get the same error on Win XP 32 bits with Qt4.6.2 and qmaking celestia.pro.
@+
Vincent

Celestia Qt4 SVN / Celestia 1.6.1 + Lua Edu Tools v1.2
GeForce 8600 GT 1024MB / AMD Athlon 64 Dual Core / 4Go DDR2 / XP SP3

ajtribick
Developer
Posts: 1807
Joined: 11.08.2003
With us: 17 years 1 month
Location: Switzerland

Re: Bug Qt-celestia SVN 5142

Post #7by ajtribick » 09.03.2011, 17:44

Ok so it looks like this breaks it for pretty much everyone. Sorry about that, will try to get a few more test configurations set up to avoid this in future. I guess we should back this one out?

Incidentally it would be nice to have a few more participants on the dev list doing more testing of patches, rather than waiting until things break (this one's been on the list for a couple of months now)... :roll:

Avatar
John Van Vliet
Posts: 2748
Joined: 28.08.2002
With us: 18 years

Re: Bug Qt-celestia SVN 5142

Post #8by John Van Vliet » 09.03.2011, 19:57

--- edit ---


Return to “Bugs”

Who is online